Skip to content

Tests: remove/update obsolete skips#19234

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
edsantiago:cleanup_skips
Jul 14, 2023
Merged

Tests: remove/update obsolete skips#19234
openshift-merge-robot merged 1 commit intocontainers:mainfrom
edsantiago:cleanup_skips

Conversation

@edsantiago
Copy link
Copy Markdown
Member

@edsantiago edsantiago commented Jul 13, 2023

To silence my find-obsolete-skips script, remove the '#'
from the following issues in skip messages:

#11784 #15013 #15025 #17433 #17436 #17456

Also update the messages to reflect the fact that the issues
will never be fixed.

Also remove ubuntu skips: we no longer test ubuntu.

Also remove one buildah skip that is no longer applicable:

Fixes: #17520

Signed-off-by: Ed Santiago santiago@redhat.com

None

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@edsantiago
Copy link
Copy Markdown
Member Author

edsantiago commented Jul 13, 2023 •
edited
Loading

Current list of FIXME-skips:

test/e2e/
  checkpoint_image_test.go:19: SkipIfContainerized("FIXME: #15015. All checkpoint tests hang when containerized.") (still open)
  checkpoint_test.go:35: SkipIfContainerized("FIXME: #15015. All checkpoint tests hang when containerized.") (still open)
  login_logout_test.go:276: // FIXME: #18405, podman-run barfs if $REGISTRY_AUTH_FILE missing (still open)
  run_test.go:1252: SkipIfRootless("FIXME: rootless users are not allowed to mount bind-nonrecursive")
  save_test.go:125: SkipIfRootless("FIXME: Need get in rootless push sign")
  search_test.go:380: Skip("FIXME FIXME FIXME #18768: This test is a NOP") (still open)
  system_connection_test.go:227: SkipIfNotRootless(fmt.Sprintf("FIXME: set up ssh keys when root. uid(%d) euid(%d)", os.Getuid(), os.Geteuid()))
  system_service_test.go:46: Skip("FIXME: Test is too flaky (#12624)") (still open)
  system_service_test.go:86: Skip("FIXME: Test is too flaky (#12624)") (still open)
  create_test.go:314: // FIXME (#18938): this test should fail but does not! (still open)

test/system/
  900-ssh.bats:24: skip "FIXME: this is not an actual test of anything"
  200-pod.bats:499: skip_if_aarch64 "FIXME: #15074 - flakes often on aarch64" (still open)

test/buildah-bud/
  apply-podman-deltas:245: skip_if_remote "FIXME FIXME FIXME: does this test make sense in remote?" \
  apply-podman-deltas:267: skip_if_remote "FIXME: can this test be made to work under podman-remote?" \
  apply-podman-deltas:271: skip_if_rootless_remote "FIXME: #17788 tar + namespaces over http" \ (still open)
  apply-podman-deltas:277: skip_if_rootless_remote "FIXME: not sure if 17788 or some other bug" \
  apply-podman-deltas:285: #skip_if_remote "FIXME: 2023-05-04: new code, fails in podman-remote" \
  apply-podman-deltas:290: skip "FIXME: 2023-06-13 buildah PR 4746 broke this test" \

@edsantiago
Tests: remove/update obsolete skips
1e94100 
To silence my find-obsolete-skips script, remove the '#'
from the following issues in skip messages:

  containers#11784 containers#15013 containers#15025 containers#17433 containers#17436 containers#17456

Also update the messages to reflect the fact that the issues
will never be fixed.

Also remove ubuntu skips: we no longer test ubuntu.

Also remove one buildah skip that is no longer applicable:

Fixes: containers#17520

Signed-off-by: Ed Santiago <santiago@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 13, 2023

LGTM

Luap99
Luap99 reviewed Jul 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit c9c46fd into containers:main Jul 14, 2023
@edsantiago edsantiago deleted the cleanup_skips branch July 17, 2023 00:38
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

podman buildx - basic test fails under rootless w/ CgroupsV1

4 participants

@edsantiago @rhatdan @Luap99 @openshift-merge-robot