"podman pull by digest and list --all" test: untag instead of rmi#18090
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Apr 7, 2023
Merged
Conversation
The "podman pull by digest and list --all" e2e test pulls an image using a tagged reference when an image with the same ID is already present in a read-only additional image store. This causes a new image record to be created in read-write storage. The test then removes this entry, pulls the image again using a digested reference, and then expects the image to not have any tagged names in it when it goes to look at it again. Newer containers/storage will ensure that at the point when the read-write image record is created, that it includes all of the data items and naming information from the read-only copy of the image, so that this information doesn't appear to be lost. Change the test to use "untag" instead of "rmi", which should pass with either the older or newer containers/storage. The test is checking that `podman images` doesn't choke when it encounters a digested name attached to an image, so the difference in behavior between containers/storage versions is irrelevant. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "podman pull by digest and list --all" e2e test pulls an image using a tagged reference when an image with the same ID is already present in a read-only additional image store.
This causes a new image record to be created in read-write storage.
The test then removes this entry, pulls the image again using a digested reference, and then expects the image to not have any tagged names in it when it goes to look at it again.
Newer containers/storage will ensure that at the point when the read-write image record is created, that it includes all of the data items and naming information from the read-only copy of the image, so that this information doesn't appear to be lost.
Change the test to use "untag" instead of "rmi", which should pass with either the older or newer containers/storage.
The test is checking that
podman imagesdoesn't choke when it encounters a digested name attached to an image, so the difference in behavior between containers/storage versions is irrelevant.Does this PR introduce a user-facing change?