speed up image listing#17973
Merged
openshift-merge-robot merged 2 commits intocontainers:mainfrom Mar 30, 2023
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
Member
|
/lgtm |
mtrmac
reviewed
Mar 29, 2023
Contributor
mtrmac
left a comment
There was a problem hiding this comment.
ACK overall. I don’t feel too strongly about that one nit.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Member
Author
|
Repushed, ready to merge. |
Contributor
|
@vrothberg this doesn’t build (and I didn’t notice) |
As found in containers#17828, image listing does not scale well with a growing number of local images. Make use of recent improvements in libimage that allow for computing the dangling and parent data with _one_ layer tree. Prior, the layer tree had to be recomputed _twice_ for each image. [NO NEW TESTS NEEDED] as it's a non-functional performance change. Fixes: containers#17828 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Member
Author
D'oh! It does now :) |
Member
Author
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found in #17828, image listing does not scale well with a growing
number of local images. Make use of recent improvements in libimage
that allow for computing the dangling and parent data with one layer
tree. Prior, the layer tree had to be recomputed twice for each
image.
Fixes: #17828
Signed-off-by: Valentin Rothberg vrothberg@redhat.com
Does this PR introduce a user-facing change?