auto-update test: wait for service to be ready#17673
Merged
openshift-merge-robot merged 2 commits intocontainers:mainfrom Mar 1, 2023
Merged
auto-update test: wait for service to be ready#17673openshift-merge-robot merged 2 commits intocontainers:mainfrom
openshift-merge-robot merged 2 commits intocontainers:mainfrom
Conversation
The symptoms in containers#17607 point to some race since it does not always flake on Debian (and Debian only). Hence, wait for the service to be ready before building the image to make sure that the service is started with the old image and that everything's in order. Fixes: containers#17607 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Member
Author
|
@containers/podman-maintainers PTAL The flake is quite annoying as Ed predicted. |
Merged
10 seconds is used by most other tests as a timeout. Given the test flakes on Debian use it. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
flouthoc
approved these changes
Mar 1, 2023
Collaborator
flouthoc
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Merging since this is needed for CI
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symptoms in #17607 point to some race since it does not always flake on Debian (and Debian only). Hence, wait for the service to be ready before building the image to make sure that the service is started with the old image and that everything's in order.
Fixes: #17607
Does this PR introduce a user-facing change?