Skip to content

fix restore API endpoint#15909

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
cdoern:restore
Sep 29, 2022
Merged

fix restore API endpoint#15909
openshift-merge-robot merged 1 commit intocontainers:mainfrom
cdoern:restore

Conversation

@cdoern
Copy link
Copy Markdown
Contributor

@cdoern cdoern commented Sep 22, 2022 •
edited
Loading

restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling on the api handlers side. add support for it here.

resolves #15018

Signed-off-by: cdoern cbdoer23@g.holycross.edu

Does this PR introduce a user-facing change?

podman-remote restore now supports --pod properly

fix restore API endpoint
2478e32 
restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling
on the api handlers side. add support for it here.

resolves containers#15018

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Sep 22, 2022
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Sep 23, 2022

LGTM

But are you sure tests are running. Shouldn't the --pod test have failed on non Ubuntu platforms in remote mode?

@vrothberg
Copy link
Copy Markdown
Member

vrothberg commented Sep 29, 2022

@cdoern ping

@cdoern
Copy link
Copy Markdown
Contributor Author

cdoern commented Sep 29, 2022

@cdoern ping

sorry, will get to this in the afternoon today

@cdoern cdoern closed this Sep 29, 2022
@cdoern cdoern reopened this Sep 29, 2022
@cdoern
Copy link
Copy Markdown
Contributor Author

cdoern commented Sep 29, 2022

@rhatdan tests are running ... but : runtime does not support pod restore: crun is output on fedora. So this was not being tested since it seems only crun is being used?

cc/ @edsantiago

@edsantiago
Copy link
Copy Markdown
Member

edsantiago commented Sep 29, 2022

Sorry... I don't understand the question. I see green CI, no failures?

IIRC the context behind this was that we were using crun in Ubuntu, and not testing runc anywhere, then this started failing once we fixed that oversight.

@cdoern
Copy link
Copy Markdown
Contributor Author

cdoern commented Sep 29, 2022

@edsantiago I'm forgetting, are we testing runc with fedora too? Because if so, this test is not being executed with runc since it was green before this PR

@edsantiago
Copy link
Copy Markdown
Member

edsantiago commented Sep 29, 2022

There is no testing of runcon fedora

@cdoern
Copy link
Copy Markdown
Contributor Author

cdoern commented Sep 29, 2022

Alright that's what I assumed, just wanted to check. In that case @rhatdan @vrothberg I think this is all set

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Sep 29, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6106864 into containers:main Sep 29, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rhatdan rhatdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

restore --pod: cannot restore pod container without --pod

5 participants

@cdoern @rhatdan @vrothberg @edsantiago @openshift-merge-robot