e2e tests: cleanup: capitalize CONSTANTS#14834
e2e tests: cleanup: capitalize CONSTANTS#14834openshift-ci[bot] merged 1 commit intocontainers:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/e2e/save_test.go
Outdated
There was a problem hiding this comment.
This was not actually part of the constant-name change; it is manual refactoring
test/e2e/search_test.go
Outdated
There was a problem hiding this comment.
Look at all these wonderful examples of ultra-confusing code
There was a problem hiding this comment.
Thanks, Ed! That is really confusing.
test/e2e/config.go
Outdated
There was a problem hiding this comment.
I left some untouched (see also below). I lean toward having those be UPCASE also, but those seem unambiguous enough, and at least they have one Capital.
0190929 to
7fb9834
Compare
A number of standard image names were lower-case, leading to
confusion in code such as:
registry := podman(... , "-n", "registry", registry, ...)
^--- variable ^---- constant
Fix a number of those to be capitalized and with _IMAGE suffix:
registry := podman(..., REGISTRY_IMAGE
Signed-off-by: Ed Santiago <santiago@redhat.com>
7fb9834 to
4fd5fb9
Compare
|
LGTM |
vrothberg
left a comment
There was a problem hiding this comment.
/lgtm
Thank you so much, Ed! It frequently confused me but I never had the courage to fix it.
A number of standard image names were lower-case, leading to
confusion in code such as:
Fix a number of those to be capitalized and with _IMAGE suffix:
Signed-off-by: Ed Santiago santiago@redhat.com