Skip to content

hack/test/utils: switch to golang native error wrapping#14829

Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
saschagrunert:errors-hack-test-utils
Jul 5, 2022
Merged

hack/test/utils: switch to golang native error wrapping#14829
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
saschagrunert:errors-hack-test-utils

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

We now use the golang error wrapping format specifier %w instead of the deprecated github.com/pkg/errors package.

None

We now use the golang error wrapping format specifier `%w` instead of
the deprecated github.com/pkg/errors package.

[NO NEW TESTS NEEDED]

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 5, 2022

LGTM

@saschagrunert saschagrunert force-pushed the errors-hack-test-utils branch 2 times, most recently from b828d0b to 49cb288 Compare July 5, 2022 10:26
@saschagrunert
Copy link
Copy Markdown
Member Author

@containers/podman-maintainers PTAL

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@openshift-ci openshift-ci bot merged commit d1e1400 into containers:main Jul 5, 2022
@saschagrunert saschagrunert deleted the errors-hack-test-utils branch July 5, 2022 11:37
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants