libpod/runtime: switch to golang native error wrapping#14789
Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom Jul 5, 2022
Merged
libpod/runtime: switch to golang native error wrapping#14789openshift-ci[bot] merged 1 commit intocontainers:mainfrom
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
792697f to
8951be1
Compare
Member
Author
|
I try to keep those PRs smaller to reduce the risk. |
27d6d91 to
48910c3
Compare
Luap99
reviewed
Jul 4, 2022
We now use the golang error wrapping format specifier `%w` instead of the deprecated github.com/pkg/errors package. [NO NEW TESTS NEEDED] Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
48910c3 to
597de7a
Compare
Member
Author
|
CI should be green. PTAL @containers/podman-maintainers |
vrothberg
reviewed
Jul 4, 2022
Member
vrothberg
left a comment
There was a problem hiding this comment.
/lgtm
/hold
Thanks, Sascha!
| func Cause(err error) (cause error) { | ||
| cause = err | ||
|
|
||
| const maxDepth = 100 |
Member
There was a problem hiding this comment.
Since memory is finite, I don't think we can run into endless loops/wrap an error indefinite times. But if an error was wrapped more than 100 times I see value in warning about it.
Member
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the golang error wrapping format specifier
%winstead of the deprecated github.com/pkg/errors package.Part of #14784
Does this PR introduce a user-facing change?