Cirrus: Use pre-installed bats by cevich · Pull Request #14719 · containers/podman

cevich · 2022-06-23T21:06:14Z

Ref: containers/automation_images#140
and
containers/automation_images#149
and
containers/automation_images#146

Does this PR introduce a user-facing change?

None

edsantiago · 2022-06-23T21:15:10Z

LGTM

edsantiago · 2022-06-23T21:45:10Z

ubuntu remote root failed every single test. Reason: /run/podman does not exist. Solution: re-run with terminal, mkdir /run/podman before the tests start. This seems to have fixed things.

@containers/podman-maintainers someone please figure out why /run/podman doesn't exist on ubuntu, and then figure out how to fix that please. @giuseppe I'm tagging you because I suspect this has something to do with XDG, whatever that is.

cevich · 2022-06-24T13:54:26Z

@edsantiago & @containers/podman-maintainers I'm 80% certain (didn't look at logs) these are most likely reproductions of the same/similar issues @lsm5 uncovered in his (open) image update PR. That's why I marked this one as dependent on his. That said, they are actual issues we need to fix, but I'm content to let Lokesh drive the update in his PR first, since he's learning how to "solo" the complete workflow. So please, head over to #14397 and see how you can help 😉

cevich · 2022-07-14T19:58:10Z

Force-push: Rebased & resolved conflict

cevich · 2022-07-15T14:45:44Z

Force-push: Updated to newer images (built yesterday).

edsantiago · 2022-07-18T11:41:39Z

Reminder: you cannot use newer images. We are frozen until criu goes stable. Which, as of this moment, it is not.

lsm5 · 2022-07-18T12:54:31Z

Reminder: you cannot use newer images. We are frozen until criu goes stable. Which, as of this moment, it is not.

It's set to land in stable, so should hopefully be done in 24 hrs or less.

cevich · 2022-07-19T14:16:11Z

Force-push: Rebased on #14963 and main, + added updated VM images built yesterday (excluding F35).

cevich · 2022-07-20T14:45:06Z

Note (happening in parallel): #14972

edsantiago · 2022-07-22T12:23:38Z

@cevich please rebase when convenient - now I can focus on reviewing this. I'm mostly out today, but will try to make time early afternoon.

edsantiago

I won't block over it, but I can't approve either.

.cirrus.yml

cevich · 2022-07-25T14:27:24Z

/hold

There's a problem with these images, new ones are needed.

edsantiago · 2022-07-26T13:45:01Z

If by "problem" you mean the ubuntu runc bug, I don't think there's any reason to block this PR on that. I'm fine with merging this.

edsantiago · 2022-07-26T14:07:27Z

/lgtm

rhatdan · 2022-07-26T14:56:28Z

/approve

openshift-ci · 2022-07-26T14:56:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cevich · 2022-07-27T18:20:06Z

Force-push: Rebased + separated VM Image update commit + use same images from #14801

vrothberg · 2022-07-28T09:25:15Z

Ready to go in?

vrothberg

/lgtm
/hold

rhatdan · 2022-07-28T14:10:23Z

Needs a rebase.

While convenient, it can be problematic to rely on a Makefile to install software. This was found to be the case across multiple environments WRT `bats`. Fix this by removing the install script and target. A future commit will ensure the correct version of `bats` is present in all CI environments where it's required. Signed-off-by: Chris Evich <cevich@redhat.com>

A prior change added extra whitespace when commenting out several sections to temporarily disable F35 testing. This restores the sections to proper indentation, so (in the future) only the `#` character needs to be removed. Signed-off-by: Chris Evich <cevich@redhat.com>

edsantiago · 2022-07-28T19:00:40Z

/lgtm

cevich requested a review from edsantiago June 23, 2022 21:06

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Jun 23, 2022

cevich mentioned this pull request Jun 23, 2022

Use packaged bats in Fedora, side-load for Ubuntu containers/automation_images#140

Merged

cevich mentioned this pull request Jun 24, 2022

[DO NOT MERGE - WIP] Cirrus: use Ubuntu 22.04 LTS #14397

Closed

cevich force-pushed the use_preinstalled_bats branch from 971e55d to 277ac44 Compare June 29, 2022 17:09

cevich mentioned this pull request Jun 30, 2022

Add support for building AWS EC2 AMIs containers/automation_images#132

Merged

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2022

cevich mentioned this pull request Jul 11, 2022

CI: runc is not being tested #14833

Closed

cevich force-pushed the use_preinstalled_bats branch from 277ac44 to 0578020 Compare July 14, 2022 19:57

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022

cevich force-pushed the use_preinstalled_bats branch from 0578020 to 20f6005 Compare July 15, 2022 14:45

cevich force-pushed the use_preinstalled_bats branch from 20f6005 to ab6d642 Compare July 19, 2022 14:15

cevich force-pushed the use_preinstalled_bats branch from ab6d642 to 80447d2 Compare July 20, 2022 15:25

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022

cevich force-pushed the use_preinstalled_bats branch from 80447d2 to d960fde Compare July 20, 2022 16:08

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022

cevich force-pushed the use_preinstalled_bats branch from d960fde to b4aed3e Compare July 20, 2022 19:54

cevich mentioned this pull request Jul 21, 2022

Bump VMs, to Ubuntu 2204 with cgroups v1 #14972

Merged

edsantiago mentioned this pull request Jul 21, 2022

Cirrus: add podman_machine_aarch64 #15031

Merged

edsantiago reviewed Jul 22, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich force-pushed the use_preinstalled_bats branch from 21a6100 to d31f9a5 Compare July 25, 2022 13:27

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022

openshift-ci bot assigned edsantiago Jul 26, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022

cevich force-pushed the use_preinstalled_bats branch from d31f9a5 to 1c699ad Compare July 27, 2022 18:19

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022

vrothberg reviewed Jul 28, 2022

View reviewed changes

openshift-ci bot assigned vrothberg Jul 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022

cevich added 2 commits July 28, 2022 11:15

cevich force-pushed the use_preinstalled_bats branch from 1c699ad to a53a0fc Compare July 28, 2022 15:29

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022

edsantiago removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022

openshift-merge-robot merged commit 509ad42 into containers:main Jul 28, 2022

cevich deleted the use_preinstalled_bats branch April 18, 2023 14:44

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023

github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023

Conversation

cevich commented Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this PR introduce a user-facing change?

Uh oh!

edsantiago commented Jun 23, 2022

Uh oh!

edsantiago commented Jun 23, 2022

Uh oh!

cevich commented Jun 24, 2022

Uh oh!

cevich commented Jul 14, 2022

Uh oh!

cevich commented Jul 15, 2022

Uh oh!

edsantiago commented Jul 18, 2022

Uh oh!

lsm5 commented Jul 18, 2022

Uh oh!

cevich commented Jul 19, 2022

Uh oh!

cevich commented Jul 20, 2022

Uh oh!

edsantiago commented Jul 22, 2022

Uh oh!

edsantiago left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cevich commented Jul 25, 2022

Uh oh!

edsantiago commented Jul 26, 2022

Uh oh!

edsantiago commented Jul 26, 2022

Uh oh!

rhatdan commented Jul 26, 2022

Uh oh!

openshift-ci bot commented Jul 26, 2022

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

vrothberg commented Jul 28, 2022

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jul 28, 2022

Uh oh!

edsantiago commented Jul 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cevich commented Jun 23, 2022 •

edited

Loading