Skip to content

[v4.1] podman system reset removed machines incorrectly#14117

Merged
openshift-merge-robot merged 1 commit intocontainers:v4.1from
openshift-cherrypick-robot:cherry-pick-14066-to-v4.1
May 4, 2022
Merged

[v4.1] podman system reset removed machines incorrectly#14117
openshift-merge-robot merged 1 commit intocontainers:v4.1from
openshift-cherrypick-robot:cherry-pick-14066-to-v4.1

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 4, 2022

This is an automated cherry-pick of #14066

/assign ashley-cui

Podman system reset now properly deletes all podman machines and associated files.

@ashley-cui
podman system reset removed machines incorrectly
d3f406e 
podman system reset did not clean up machines fully, leaving some config
files, and breaking machines. Now it removes all machines files fully.

Signed-off-by: Ashley Cui <acui@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2022
Merged
@baude
Copy link
Copy Markdown
Member

baude commented May 4, 2022

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@baude
Copy link
Copy Markdown
Member

baude commented May 4, 2022

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@mheon
Copy link
Copy Markdown
Member

mheon commented May 4, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6e8f637 into containers:v4.1 May 4, 2022
@edsantiago edsantiago added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@baude baude

@ashley-cui ashley-cui

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @baude @mheon @edsantiago @openshift-merge-robot @ashley-cui