play kube default log driver#14060
play kube default log driver#14060openshift-merge-robot merged 1 commit intocontainers:mainfrom nicrowe00:13781
Conversation
|
@vrothberg PTAL |
vrothberg
left a comment
There was a problem hiding this comment.
LGTM
@containers/podman-maintainers PTAL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nicrowe00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
left a comment
There was a problem hiding this comment.
I am not sure how the test actually makes sure the correct default is chosen. It should not rely on the default value. Instead use a custom containers.conf and test with both journald and k8s-file as default.
The current patch will also not work via remote. The defaults must be set on server side.
The entire point is to use the default value.
Good point. I didn't test it with remote yet. We'll probably need some further tweaks for the remote code. |
|
All kinds of tests unhappiness. |
vrothberg
left a comment
There was a problem hiding this comment.
The remote int flakes are unrelated.
The default log driver is not used when using play kube without --log-driver. The LogDriver function needs to be called in order to use the default log driver. fixes #13781 Signed-off-by: Niall Crowe <nicrowe@redhat.com>
|
@containers/podman-maintainers PTAL I restarted the flaked job. |
|
LGTM |
|
/lgtm |
The default log driver is not used when using play kube
without --log-driver. The LogDriver function needs to
be called in order to use the default log driver.
fixes #13781
Signed-off-by: Niall Crowe nicrowe@redhat.com