Workaround criu re-linking output in system test#13958
Workaround criu re-linking output in system test#13958openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
|
This is nauseating and offensive (not your fault - I mean, the need for this workaround). I'm really sorry, but could I ask you to resubmit with a loud FIXME comment explaining the reason for the |
|
Oh thanks for looking up the underlying issue. I can add a |
When run on an F36 host using netavark/aardvark-dns, for whatever underlying reason most checkpoint/restore tests are emitting an error similar to: `criu: Symbol `__rseq_offset' has different size in shared object, consider re-linking` This extraneous output is causing the basic checkpoint system test to fail. Since, all other testing of checkpoint/restore feature is passing (also with the extraneous message) loosen the system test sensitivity to match. Signed-off-by: Chris Evich <cevich@redhat.com>
71035bc to
93ecafc
Compare
They're actually not - I have a script that I run periodically to check for them. (It prefers FIXMEs with actual issue numbers which it can cross-check against github, and we don't have that here, but I'll still find it one day. Without a FIXME, I'll never see it again). |
Of course you do! 🤣 |
|
LGTM |
|
/lgtm thanks for the comment! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@edsantiago thanks for reporting! It looks related to this change in Glibc: You have CRIU built on the system with one Glibc version but run it on the system with a different version. Is it a common scenario for you? If yes, then we need to rework our approach by getting the |
@mihalicyn I think in this case we have CRIU installed from a package and the CRIU package is not automatically rebuild when the glibc package is updated. |
|
I should have checked and rebuilt We can't easily fix this right now because Fedora 36 is in final freeze before the release. I can try to get a freeze exception, but it's probably easier to wait a few days until the release if that's okay. Just to repeat, this a Fedora-specific problem which will go away once the |
|
@rst0git @fweimer-rh Thanks, guys. Please, ping me If I need to rework or fix something :) |
When run on an F36 host using netavark/aardvark-dns, for whatever
underlying reason most checkpoint/restore tests are emitting an error
similar to:
criu: Symbol__rseq_offset' has different size in shared object,consider re-linking`
This extraneous output is causing the basic checkpoint system test to
fail. Since, all other testing of checkpoint/restore feature is
passing (also with the extraneous message) loosen the system test
sensitivity to match.
Signed-off-by: Chris Evich cevich@redhat.com