Cirrus: Fix missing git-enforced runtime identity#13956
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Apr 22, 2022
Merged
Cirrus: Fix missing git-enforced runtime identity#13956openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
Newer versions of git (like `2.35`) fail on certain operations (like `rebase` and `am`) without a local identity. Add a fake one from the start, with a clearly identifiable test-value to avoid problems at runtime. Signed-off-by: Chris Evich <cevich@redhat.com>
Member
|
This is really brain dead on gits part but, |
Member
Author
I agree, and Ed found some connection to a hostname lookup problem of all things. Ya, this is the least-ugly way of moving forward I think 😞 |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of git (like
2.35) fail on certain operations (likerebaseandam) without a local identity. Add a fake one from thestart, with a clearly identifiable test-value to avoid problems at
runtime.
Note: This has to be done twice to cover all tasks that need it. I tried to avoid the duplication, but it wound up being more complex 😖