Add build test for .containerignore tar file#13665
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Apr 1, 2022
Merged
Add build test for .containerignore tar file#13665openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
rhatdan
reviewed
Mar 26, 2022
flouthoc
reviewed
Mar 29, 2022
eb85d12 to
0b75c11
Compare
Ensure a directory added to .containerignore on client is not included in tar sent to remote podman API service * Clean up podman invocations to not include duplicate --remote and --url flags * Use pkill vs. pgrep when cleaning up podman API service in tests * Add exit code when logging error when testing Closes containers#13535 Signed-off-by: Jhon Honce <jhonce@redhat.com>
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure a directory added to .containerignore on client is not included
in tar sent to remote podman API service
--url flags
Closes #13535
Signed-off-by: Jhon Honce jhonce@redhat.com