[release-5.36] rekor: do not cancel http context#2943
Merged
Luap99 merged 1 commit intocontainers:release-5.36from Aug 26, 2025
Merged
[release-5.36] rekor: do not cancel http context#2943Luap99 merged 1 commit intocontainers:release-5.36from
Luap99 merged 1 commit intocontainers:release-5.36from
Conversation
The context must be valid for the entire lifetime of the request including reading the body, as such it is invalid to return the body after cancelling the context, depending of if all the response data arrived already or not this then might fail. To fix this simply do not cancel the context here, we could move the cancel() up to the caller function that processes the body. However as that one already closes the body there should be no need to cancel the context to end the request. Fixes: containers#2936 Fixes: https://issues.redhat.com/browse/RHEL-111077, https://issues.redhat.com/browse/RHEL-111076 Signed-off-by: Paul Holzinger <pholzing@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
mtrmac
reviewed
Aug 26, 2025
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
LGTM for the record. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context must be valid for the entire lifetime of the request including reading the body, as such it is invalid to return the body after cancelling the context, depending of if all the response data arrived already or not this then might fail.
To fix this simply do not cancel the context here, we could move the cancel() up to the caller function that processes the body. However as that one already closes the body there should be no need to cancel the context to end the request.
Fixes: #2936
Fixes: https://issues.redhat.com/browse/RHEL-111077, https://issues.redhat.com/browse/RHEL-111076