Add link to c/common contributor's guide#2776
Merged
mtrmac merged 1 commit intocontainers:mainfrom Mar 17, 2025
Merged
Conversation
mtrmac
reviewed
Mar 13, 2025
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
Question for reviewer: I don't know if the communication part is still valid? If it's deprecated and I can remove it.
I don’t know who, if anyone, ever was on that IRC channel. I never visited. Please drop it.
In case it makes a difference:
- We don’t typically require 2 LGTMs — few people are watching the repo
- There is no
OWNERSfile (see #2591 ) — it’s targeted at bots that are not active in the repo - (In the c/common file,
https://developercertificate.orgshould behttps, it redirects there anyway)
I don’t care much about these details being recorded — I think that external PR authors are’t really affected, and what we do in practice is ultimately more important. But there might be a reason to be accurate, so I’m pointing these out just in case.
cd8fd01 to
e2804f1
Compare
Member
Author
|
I removed the section on communication and mentioned the differences. |
e2804f1 to
37f2cae
Compare
Fixes: https://issues.redhat.com/browse/RUN-2321 Signed-off-by: Jan Rodák <hony.com@seznam.cz>
37f2cae to
1436227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a link to the updated c/common contributor's guide to reduce the costs of updating the contribution guide and removes duplicate information.
Question for reviewer: I don't know if the communication part is still valid? If it's deprecated and I can remove it.
Fixes: https://issues.redhat.com/browse/RUN-2321