Merged
Conversation
mtrmac
reviewed
Mar 7, 2025
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Looks good, please squash the two commits.
cfcd1b9 to
d05965d
Compare
Contributor
Author
done~ |
Contributor
Author
|
/retest |
Contributor
Author
|
it seems that some task failed.
Maybe it's problem of ci machine, is there any way to re-run the test case? |
Collaborator
|
Please rebase now, the test failure should be resolved. |
Signed-off-by: warjiang <1096409085@qq.com>
Contributor
Author
|
ci passed, let's move forward 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dockerClient will use http client to fetch manifest、blob and do some network request. Golang build-in http library will use
HTTP_PROXY、HTTPS_PROXYenvironment variables to config proxy for network. But the environment variables cannot make flexible control of proxy behaviours. So I want to declare proxy configuration explicitly.