Merged
Conversation
mtrmac
requested changes
Mar 5, 2025
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks; can you also rebase to avoid the merge commit, please?
docker/docker_client.go
Outdated
| // streamLen, if not -1, specifies the length of the data expected on stream. | ||
| // makeRequest should generally be preferred. | ||
| // Note that no exponential back off is performed when receiving an http 429 status code. | ||
| // Note that no exponential back off is performed when receiving a http 429 status code. |
Collaborator
There was a problem hiding this comment.
This one is actually (mostly considered to be) correct; Google finds https://www.pristineword.com/grammar-an-http/ .
Contributor
Author
There was a problem hiding this comment.
The difference between an HTTP and a HTTP is really insteresting, I got it. Thanks for pointing that.
Signed-off-by: warjiang <1096409085@qq.com>
Contributor
Author
It already done~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to set proxy for single-side image proxy(only for src-image or dest-image, maybe you can combine these two proxy options) and find some err, fix it by the way