Update for c/storage almost always computing UncompressedDigest#2680
Merged
vrothberg merged 1 commit intocontainers:mainfrom Jan 10, 2025
Merged
Update for c/storage almost always computing UncompressedDigest#2680vrothberg merged 1 commit intocontainers:mainfrom
vrothberg merged 1 commit intocontainers:mainfrom
Conversation
We will want c/storage to do that in order to avoid the traditional/partial "view" ambiguity. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Collaborator
Author
|
Podman tests (corresponding to the previous failure) are passing in containers/podman#24991 , this is ready for review. |
Member
|
LGTM |
vrothberg
approved these changes
Jan 10, 2025
Member
|
Late, but LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After containers/storage#2155 , we ~always compute
UncompressedDigest, but the current code was expecting that to happen only whenconvert_imagesis set (and we consume the whole compressed blob).That is breaking pulls of chunked images, e.g. https://api.cirrus-ci.com/v1/artifact/task/6559054106984448/html/sys-podman-debian-13-rootless-host-sqlite.log.html :
Update the code to not blindly assume that
CompressedDigestis set, and to expectUncompressedDigestto be set much more frequently. Originally from #2613 , and tested as a part of the full patch set.Separate Podman tests to confirm this truly fixes the test failure: containers/podman#24991 .
@giuseppe PTAL.