Fix docker daemon on Windows trying to use https instead of http for named pipes#2666
Merged
mtrmac merged 1 commit intocontainers:mainfrom Jan 2, 2025
Merged
Conversation
Signed-off-by: Brandyn Bayes <brbayes@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects an issue where previously connections to the Docker daemon on Windows would attempt to add a TLS config, changing the scheme to https instead of http, and breaking the client. This changes named pipes (returned as
npipeby the docker client library) to mimic the behavior of unix sockets.I tried to add tests for this case, but the base transport and scheme variables are not exposed from the docker client, so there wasn't a clear way to test this change. I have tested this locally on a Windows machine, ensuring that accessing the daemon works after this change.