Fix a missing s.lock.Unlock() on an error path#2643
Merged
vrothberg merged 1 commit intocontainers:mainfrom Nov 28, 2024
Merged
Fix a missing s.lock.Unlock() on an error path#2643vrothberg merged 1 commit intocontainers:mainfrom
vrothberg merged 1 commit intocontainers:mainfrom
Conversation
cgwalters
reviewed
Nov 27, 2024
storage/storage_dest.go
Outdated
| if uncompressedDigest := options.Cache.UncompressedDigestForTOC(out.TOCDigest); uncompressedDigest != "" { | ||
| s.lockProtected.indexToDiffID[options.LayerIndex] = uncompressedDigest | ||
| if err := func() error { // A scope for defer | ||
| s.lock.Unlock() |
Contributor
There was a problem hiding this comment.
Shouldn't this have a defer?
Collaborator
Author
There was a problem hiding this comment.
Oh wow, that’s embarrassing. 🤦
Thanks!
... and use defer to avoid that bug in the future. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and use
deferto avoid that bug in the future.(Split from larger work as an independent piece. Reviewing is easier when ignoring whitespace changes.)