Assorted clean ups, optimizations, and a small bug fix#2552
Merged
rhatdan merged 6 commits intocontainers:mainfrom Sep 5, 2024
Merged
Assorted clean ups, optimizations, and a small bug fix#2552rhatdan merged 6 commits intocontainers:mainfrom
rhatdan merged 6 commits intocontainers:mainfrom
Conversation
Member
|
LGTM |
Append the result directly into the returned array, instead of assembling it from partial pieces. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Make it 1-based, like in the other error message. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It can't fail. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We do modify cs in place. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
I’m happy to split this into separate PRs for separate review; let me know.