Introduce/use JSONFormatToInvalidSignatureError#2518
Merged
mtrmac merged 2 commits intocontainers:mainfrom Aug 19, 2024
Merged
Conversation
Closed
mtrmac
approved these changes
Aug 19, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
I’m not sure this is worth it as such, either, but on balance, let’s do it:
- The unrelated typo fixes are certainly valuable :)
- Rule of thumb, “deduplicate when there are 3 copies”
- Ideally, we’d like some kind of “unmarshaling is an
InvalidSignatureError” helper/mix-in, but the only way I know how to do that in Go would be… which costs an extra interface pointer fortype signatureUnmarshaler struct { underlying interface { strictUnmarshalJson(…)…} type UntrustedRekorSET { signatureUnmarshaler; … }
this.UntrustedRekorSET.signatureUnmarshaler.underlying == this, and doesn’t work at all forUnmarshalJSONbecause that doesn’t call any construct which would setunderlying.
This is a helper to avoid code repetition. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
f6351fd to
a710dc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a patch from #2512.
Feel free to close if it doesn't make much sense (I'm on the verge).