manifest: LayerInfos: preallocate the slice#2499
Merged
mtrmac merged 1 commit intocontainers:mainfrom Aug 5, 2024
Merged
Conversation
Member
|
LGTM |
mtrmac
reviewed
Aug 5, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
WDYT about make(…, 0, len(…)) + continuing to use append?
I think that achieves the primary optimization goal (not over-allocating, and not calling an allocation function in the loop) without giving up on safety WRT hypothetical future logic changes — at some performance cost, 2 conditional jumps per loop instead of one (sadly, per https://godbolt.org/z/Gbo98a74K , Go can optimize out the range check in [i], but not the capacity check in append).
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
I thought about that, but since we don't do any filtering inside the loop here I went another way. Changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.