Merged
Conversation
This is to prevent codespell from complaining about pathc -> patch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use ok instead of isT and isV, and limit the variables scope. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
s/doesnt/does-not/ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This just changes fo to f, without disrupting the test. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This fixes a comment in the test code ("expection", "out", and
punctuation) to the best of my knowledge.
Fixes: c84a3fa ("copy/multiple_test: multiple copy requests of same compression")
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
Nice; I have codespell 2.2.6 locally, while in CI we use 2.3.0 which (thanks to cleaned .codespellrc) caught yet another typo: |
Found by codespell 2.3.0: Error: ./copy/single.go:217: resuing ==> reusing, resuming, rescuing Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Current .codespellrc contains too many exclusions, and as a result it misses some legitimate typos. A few previous commits silenced or fixed some of the codespell warnings in preparation for this one, which minimizes exclusions, and fixes the actual remaining typos. The fixes here are the result of codespell -w. ./copy/sign_test.go:119: overidden ==> overridden ./copy/encryption.go:51: pratice ==> practice ./copy/multiple_test.go:80: crated ==> created ./copy/progress_bars.go:124: progres ==> progress Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
Split into small commits for easier review.