Skip to content

Update a comment after a c/storage update#2299

Merged
vrothberg merged 1 commit intocontainers:mainfrom
mtrmac:PutLayer-improvements
Feb 20, 2024
Merged

Update a comment after a c/storage update#2299
vrothberg merged 1 commit intocontainers:mainfrom
mtrmac:PutLayer-improvements

Conversation

@mtrmac
Copy link
Copy Markdown
Collaborator

@mtrmac mtrmac commented Feb 15, 2024

This updates for the trivial half of containers/storage#1830.

It does not update to benefit from the more important part (creating the reused layers with the right CompressedDigest/CompressedSize) — that also should happen, but it’s a tiny bit of work and not an immediate priority.

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 17, 2024

Needs a rebase.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the PutLayer-improvements branch from 4aeff8f to d8b2b98 Compare February 19, 2024 22:54
@mtrmac mtrmac changed the title Update c/storage and a comment about that Update a comment after a c/storage update Feb 19, 2024
@mtrmac
Copy link
Copy Markdown
Collaborator Author

mtrmac commented Feb 20, 2024

Rebased, now just a comment update.

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrothberg vrothberg merged commit f42a082 into containers:main Feb 20, 2024
@mtrmac mtrmac deleted the PutLayer-improvements branch February 20, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants