Remove dependencies on k8s.io/apimachinery#225
Closed
mtrmac wants to merge 3 commits intocontainers:masterfrom
Closed
Remove dependencies on k8s.io/apimachinery#225mtrmac wants to merge 3 commits intocontainers:masterfrom
mtrmac wants to merge 3 commits intocontainers:masterfrom
Conversation
Instead, copy the error.NewAggregate implementation inside. This allows use of this package in OpenShift, which uses an older version of k8s.io packages. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Instead, inline net.SetTransportDefaults and copy net.NewProxierWithNoProxyCIDR. This allows use of this package in OpenShift, which uses an older version of k8s.io packages. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This was referenced Jan 23, 2017
Member
|
👍 |
Collaborator
Author
|
… broken again, by kubernetes/kubernetes@335ef74 . |
Contributor
|
Sorry to distract.
I was working on a vendoring patch to help solve this problem in a few
spots (github.com/Microsoft has a few gems too if you guys have been
watching the things I tagged you on).
I think (open)containers needs to settle on a global vendoring solution.
This "rsync into dir" does not scale for the reasons we're seeing now.
A well defined, centralized dep list would go a long way towards stability
in the projects (due to matched deps) and also make it easier to isolate
problems.
However, I lack the political clout to carry out such an action. If this is
a desired thing I can put together the patches across
openshift/opencontainers/containers to sync this all up to standardized
versions and maybe settle on `hack/vendor.sh` or godep to keep the
repositories small since they only import parts of repos. I talked to alex
on the vndr project and he told me vndr cannot do subsets of repositories;
making it so that we have to import all of docker/docker for
docker/pkg/term.
Anyways, I can open an issue/set of issues if you think this is a good idea.
…On Mon, Jan 23, 2017 at 10:16 AM, Miloslav Trmač ***@***.***> wrote:
… broken again, by ***@***.***
<kubernetes/kubernetes@335ef74>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#225 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABJ66bEhwFqISn3565i-cG-VAhnkJFRks5rVO5tgaJpZM4LrXEc>
.
|
Collaborator
Author
While I would certainly like not having to care, the trouble is that we don’t want to freeze the versions forever; if this did succeed and we had 20 projects using a centralized dependency list, it would in turn be politically very difficult to change the list in the future. The various upstreams do add quite a few bug fixes, not only breaking changes, and we do want to get those bug fixes with little hassle :) Sharing a dependency list between
That may be misleading: with |
Contributor
|
Hmm. @LK4D4 told me otherwise, perhaps he's willing to comment?
…On Mon, Jan 23, 2017 at 10:38 AM, Miloslav Trmač ***@***.***> wrote:
A well defined, centralized dep list would go a long way towards stability
in the projects (due to matched deps) and also make it easier to isolate
problems.
While I would certainly like not having to care, the trouble is that we
don’t want to freeze the versions *forever*; if this did succeed and we
had 20 projects using a centralized dependency list, it would in turn be
politically very difficult to change the list in the future. The various
upstreams do add quite a few bug fixes, not only breaking changes, and we
do want to get those bug fixes with little hassle :)
Sharing a dependency list between skopeo and containers/image does sound
very attractive, but with that we would probably have not encountered the
recent breaking changes for a good few months, if not years—which would
*not* make the porting work smaller, it would only aggregate it in time
to a single week (and probably a time when it would be much more urgent
than now, when we are haunted only by our own CI).
I talked to alex on the vndr project and he told me vndr cannot do subsets
of repositories; making it so that we have to import all of docker/docker
for docker/pkg/term.
That may be misleading: with vndr, one has to record an *entire*
repository in vendor.conf, and perhaps all of that repository is pulled
into a temporary directory, but the resulting vendor/github.com/docker
directory is pruned to only contain the actually used subpackages.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#225 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABJ6whoyLlex9kv2dwtaSm3BjwejaIZks5rVPPDgaJpZM4LrXEc>
.
|
Contributor
|
Either way, the vendoring tool doesn't concern me much; the centralized
list does.
I agree the list would be hard to change; that is a huge problem to solve.
I'll think about this and start another ticket when I have actual plans. :)
…On Mon, Jan 23, 2017 at 10:44 AM, Erik Hollensbe ***@***.***> wrote:
Hmm. @LK4D4 told me otherwise, perhaps he's willing to comment?
On Mon, Jan 23, 2017 at 10:38 AM, Miloslav Trmač ***@***.***
> wrote:
> A well defined, centralized dep list would go a long way towards
> stability in the projects (due to matched deps) and also make it easier to
> isolate problems.
>
> While I would certainly like not having to care, the trouble is that we
> don’t want to freeze the versions *forever*; if this did succeed and we
> had 20 projects using a centralized dependency list, it would in turn be
> politically very difficult to change the list in the future. The various
> upstreams do add quite a few bug fixes, not only breaking changes, and we
> do want to get those bug fixes with little hassle :)
>
> Sharing a dependency list between skopeo and containers/image does sound
> very attractive, but with that we would probably have not encountered the
> recent breaking changes for a good few months, if not years—which would
> *not* make the porting work smaller, it would only aggregate it in time
> to a single week (and probably a time when it would be much more urgent
> than now, when we are haunted only by our own CI).
>
> I talked to alex on the vndr project and he told me vndr cannot do
> subsets of repositories; making it so that we have to import all of
> docker/docker for docker/pkg/term.
>
> That may be misleading: with vndr, one has to record an *entire*
> repository in vendor.conf, and perhaps all of that repository is pulled
> into a temporary directory, but the resulting vendor/github.com/docker
> directory is pruned to only contain the actually used subpackages.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#225 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABJ6whoyLlex9kv2dwtaSm3BjwejaIZks5rVPPDgaJpZM4LrXEc>
> .
>
|
|
@erikh everything unused is pruned, but what is used has the same version within project, so all deps which starts from i.e. |
Contributor
|
gotcha; misunderstood. thanks alex.
vndr should work fine, then! :)
…On Mon, Jan 23, 2017 at 10:49 AM, Alexander Morozov < ***@***.***> wrote:
@erikh <https://github.com/erikh> everything unused is pruned, but what
is used has the same version within project, so all deps which starts from
i.e. github.com/coreos/etcd will have same version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABJ6yvLPBglosI0d_VTJ2GfC6a9-55Tks5rVPYvgaJpZM4LrXEc>
.
|
…o/client-go Because this is an entirely new package, depending on any version of it should hopefully not be problematic for downstreams. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Collaborator
Author
|
Updated to also handle the |
Merged
Member
|
this has been included in #223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #207 (comment) , depending on the latest versions of
k8s.iomakes this code very difficult to use inopenshift/origin. So, drop dependencies onk8s.io/apimachinery/pkg/util/{error,net}by inlining or copying the necessary parts.(This leaves
k8s.io/pkg/util/homedir, which seems not to cause issues right now.)