UNTESTED: Replace sigstore/rekor/pkg/client with a manually-created client#1845
Closed
mtrmac wants to merge 1 commit intocontainers:mainfrom
Closed
UNTESTED: Replace sigstore/rekor/pkg/client with a manually-created client#1845mtrmac wants to merge 1 commit intocontainers:mainfrom
mtrmac wants to merge 1 commit intocontainers:mainfrom
Conversation
Member
|
@lukehinds PTAL |
Member
|
I like the idea of shrinking the executable, hopefully this same shrinkage would apply to Podman. |
Collaborator
Author
|
Note to self: This should probably only be merged after we have integration tests against a Rekor server. |
16 tasks
mtrmac
commented
Feb 13, 2023
Member
|
Needs a rebase |
dc3aa79 to
9f5a14f
Compare
d1f2d9e to
bbcafde
Compare
…lient This removes 4.728 MB from a macOS Skopeo binary. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Member
|
replaced by #2873 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes 4.728 MB from a macOS Skopeo binary.
The costs are:
Content-Type:header in the response. This one asks for JSON and expects JSON.Absolutely untested, pretty likely to be broken due to some some fairly trivial but critical typo. Filing early to give more opportunity to review / discuss.