Skip to content

[release-5.24] Reconnecting blob reader#1832

Merged
rhatdan merged 4 commits intocontainers:release-5.24from
mtrmac:eof-range-requests-5.24
Feb 9, 2023
Merged

[release-5.24] Reconnecting blob reader#1832
rhatdan merged 4 commits intocontainers:release-5.24from
mtrmac:eof-range-requests-5.24

Conversation

@mtrmac
Copy link
Copy Markdown
Collaborator

@mtrmac mtrmac commented Feb 7, 2023

This is a backport of #1816

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is quite loud in case it decides not to reconnect,
so that we can have an idea of the failing situations.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac changed the base branch from main to release-5.24 February 7, 2023 02:10
@mtrmac
Copy link
Copy Markdown
Collaborator Author

mtrmac commented Feb 8, 2023

Today’s decision was to add this, and to tag 5.24.1. @vrothberg PTAL.

@mtrmac mtrmac marked this pull request as ready for review February 8, 2023 17:06
@mtrmac mtrmac changed the title [release-5.24] DO NOT MERGE: Reconnecting blob reader [release-5.24] Reconnecting blob reader Feb 8, 2023
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Feb 8, 2023
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add two commits for the version dumps directly?

- Try to reconnect on _some_ aborted layer downloads

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Copy Markdown
Collaborator Author

mtrmac commented Feb 9, 2023

Sure, version bump added.

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Feb 9, 2023

LGTM

@rhatdan rhatdan merged commit ab3f42c into containers:release-5.24 Feb 9, 2023
@mtrmac mtrmac deleted the eof-range-requests-5.24 branch February 9, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature A request for, or a PR adding, new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants