GPG signing test improvements#1779
Merged
vrothberg merged 5 commits intocontainers:mainfrom Jan 9, 2023
Merged
Conversation
... because we will add more users. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
.. so that we don't leave around long-term state. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
4b7021f to
cd59118
Compare
That will make it easier to change the copier.createSignature API. Should not change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Separate "exceptional situations" tests from tests of identity handling. Should not change (test) behavior Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
cd59118 to
bc1c975
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
copy/sign_test.goto be table-driven, and cleans it up a bit more, to make it easier to update in Introduce opaque signer.Signer objects #1776gpg-agentprocesses spawned by tests (compare Tests leak gpg agent / gpg processes #224 )Only modifies tests, should not change behavior.