Add a Cosign signature format carrier#1594
Merged
mtrmac merged 1 commit intocontainers:mainfrom Jul 7, 2022
Merged
Conversation
1447883 to
2f6f7a5
Compare
This was referenced Jul 6, 2022
Merged
2f6f7a5 to
97eed15
Compare
Collaborator
Author
Ready for review, apart from the previous-PR dependency. |
97eed15 to
cd1d264
Compare
vrothberg
reviewed
Jul 7, 2022
Member
vrothberg
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge once the merge-rebase dance is done
cd1d264 to
61d26a4
Compare
Currently, this just allows serializing and deserializing it as a blob. NOTE: This makes an implementation decision about the blob format: we use OpenPGP signatures with no marker, any new formats will start with a zero byte and an ASCII line identifying the format of the rest. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
61d26a4 to
c8e8246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a way to represent the signature, for other code to read/write it, or create/consume it.
NOTE: This, along with #1593, makes a design decision about how we are going to represent signatures as[]bytein stable storage. That has long-term consequences.Depends on unmerged #1593.