Skip to content

Small cleanups#602

Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
cfergeau:cleanups
Feb 4, 2026
Merged

Small cleanups#602
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
cfergeau:cleanups

Conversation

@cfergeau
Copy link
Copy Markdown
Collaborator

@cfergeau cfergeau commented Jan 28, 2026

3 unrelated cleanups,

  • build: Update .gitignore
  • tap: Switch no longer need to know the MTU
  • deps: Switch back to github.com/inetaf/tcpproxy

The bug which made us use our own tcpproxy copy no longer seems to occur.
It was most likely related to inetaf/tcpproxy@48c7e53
This reverts c315e61.
This fixes containers#387

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
The MTU-related code has been part of tap.LinkEndpoint for a while now.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Ignore both bin/ and tools/bin/
The ./bin/ pattern used before this commit was matching neither of
these.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
@vyasgun
Copy link
Copy Markdown
Member

vyasgun commented Feb 2, 2026

Looks good to me
/approve

@praveenkumar
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, praveenkumar, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 74c28a6 into containers:main Feb 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants