Merged
Conversation
This is slightly better if ipv6 is used, which is not the case yet. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This should fix containers#545 MaxInt32 should be strictly smaller than MaxUint32 and thus fit both in an int32 and an uint32. This fixes this compilation error: ``` pkg/tap/protocols.go:56:12: math.MaxUint32 (untyped int constant 4294967295) overflows int ``` Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
pkg/transport/unixgram_darwin.go:62:3: S1008: should use 'return !errors.Is(getRemoteAddrErr, syscall.EAGAIN)' instead of 'if errors.Is(getRemoteAddrErr, syscall.EAGAIN) { return false }; return true' (staticcheck)
if errors.Is(getRemoteAddrErr, syscall.EAGAIN) {
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unbreak
make cross-lintbeing currently broken in CI.This also fixes a compilation breakage on arm32.