Add make cross-lint target for cross-platform linting #538
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Sep 9, 2025
Merged
Add make cross-lint target for cross-platform linting #538openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Conversation
- Add cross-lint target that runs linting for Linux, macOS, and Windows Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
cfergeau
reviewed
Aug 21, 2025
Collaborator
cfergeau
left a comment
There was a problem hiding this comment.
/lgtm
One minor change needed (the removed // +build windows)
Collaborator
|
Can 'cross-lint' be used instead of |
0036378 to
3c47ff1
Compare
cfergeau
reviewed
Sep 1, 2025
Collaborator
cfergeau
left a comment
There was a problem hiding this comment.
Looks good to me. Some of the commits are missing a signed-off-by, apart from that, it’s good to go after a green CI run.
db404b5 to
11fb618
Compare
Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
11fb618 to
6c03de3
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #513