Don't show an ERROR when ignoring a RELEASE message#529
Don't show an ERROR when ignoring a RELEASE message#529openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
The RELEASE message is optional anyways, so not handling it is not a critical error that a user needs to worry about. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
lstocchi
left a comment
There was a problem hiding this comment.
LGTM, maybe we could update the log message as this is actually handled now.
Something like log.Debugf("dhcp: received RELEASE message for client %s", m.ClientHWAddr.String())
We don’t do anything with the message, only print a log, so it’s not really handled, the log would need to indicate the message is ignored or such. I’m fine with "unhandled" for now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, jandubois The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The RELEASE message is optional anyways, so not handling it is not a critical error that a user needs to worry about.
Lima users are getting confused about the error message when they shut down a VM: lima-vm/lima#3776