gvproxy: Add --pcap option#501
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Apr 28, 2025
Merged
Conversation
Instead of always writing to a `capture.pcap` file in the current directory when --debug is used, this commit introduces a separate --pcap argument, which can also be used to specify the path to the capture file. These pcap files can get huge, and are not always useful when debug logs are requested, so it’s better to separate --debug and --pcap. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The 20.04 image is deprecated and will soon be removed. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
go 1.22 is no longer supported upstream, and gvisor-tap-vsock switched to go 1.23 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Member
|
I tried this patch and it works for me |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always writing to a
capture.pcapfile in the currentdirectory when --debug is used, this commit introduces a separate --pcap
argument, which can also be used to specify the path to the capture
file.
These pcap files can get huge, and are not always useful when debug logs
are requested, so it’s better to separate --debug and --pcap.