fix vfkit socket disposal#486
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Mar 12, 2025
Merged
Conversation
when disposing the vfkit socket, gvproxy fails at removing it bc it tries to remove the unixgram uri (e.g. unixgram:///var/folders/n4/n5hyrstd2739lcy9903jn8f40000gn/T/podman/podman-gvproxy.sock). This patch fixes it by extracting the path from the uri. Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
cfd2d76 to
4bbb832
Compare
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, lstocchi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when disposing the vfkit socket, gvproxy fails at removing it bc it tries to remove the unixgram uri (e.g. unixgram:///var/folders/n4/n5hyrstd2739lcy9903jn8f40000gn/T/podman/podman-gvproxy.sock). This patch fixes it by extracting the path from the uri.