Trim 'search' list field on macOS#478
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Mar 4, 2025
Merged
Trim 'search' list field on macOS#478openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
According to macOS 'man 5 resolver' 'search' is limited to six domains with a total of 256 characters. This commit uses only 256/6 domains and cuts rest. Since glibc 2.26 Linux has no limitation on 'search'. Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
bdc91a4 to
788ed77
Compare
cfergeau
approved these changes
Mar 4, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
0acc12d
into
containers:main
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to macOS 'man 5 resolver' 'search' is limited to six domains with a total of 256 characters. This commit uses only 256/6 domains and cuts rest.
Fixes #474
I have check that with
in
/etc/resolv.confwith his PR podman machine is starting successfully