Skip to content

Run unit tests on linux#457

Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
lstocchi:i452
Jan 13, 2025
Merged

Run unit tests on linux#457
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
lstocchi:i452

Conversation

@lstocchi
Copy link
Copy Markdown
Collaborator

@lstocchi lstocchi commented Jan 13, 2025 •
edited
Loading

b525dc8#r1909010646 updated the gh workflow to run tests. However, it causes some tests to not being run anymore.
This patch re-add back the test command and filters the vfkit tests using the go build tag

it fixes #452

@lstocchi
add build tag to vfkit test files
486a03b 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi
add back the generic test command and use it on gh workflow
0f43aa9 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from cfergeau and evidolob January 13, 2025 14:04
cfergeau
cfergeau approved these changes Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cfergeau cfergeau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

These testing targets deserve a larger overhaul at some point. We should be running all the tests which do not need virtualization on macos/linux/windows, and then run the tests which require virtualization on a linux runner since it is the only place where they can run.

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, lstocchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 56369d1 into containers:main Jan 13, 2025
@cfergeau
Copy link
Copy Markdown
Collaborator

cfergeau commented Jan 13, 2025

These testing targets deserve a larger overhaul at some point. We should be running all the tests which do not need virtualization on macos/linux/windows, and then run the tests which require virtualization on a linux runner since it is the only place where they can run.

I created #458 to track this.

@lstocchi lstocchi deleted the i452 branch January 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfergeau cfergeau cfergeau approved these changes

@evidolob evidolob Awaiting requested review from evidolob

Assignees

@cfergeau cfergeau

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit tests are no longer run in github actions

2 participants

@lstocchi @cfergeau