Upload and Download tests against vfkit#453
Upload and Download tests against vfkit#453openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
62f231d to
730f708
Compare
lstocchi
left a comment
There was a problem hiding this comment.
Overall LGTM, just a suggestion to reduce duplicate code
730f708 to
8e45dda
Compare
09652f1 to
8e45dda
Compare
evidolob
left a comment
There was a problem hiding this comment.
In current state test not testing what it intend, see comment for for loop
I prefer to have this test wrapped with Describe with some cleanup code in AfterEach. As multiple test runs will easily overflow laptop ssd.
If you are looking on samples how to doit, see https://onsi.github.io/ginkgo/#spec-cleanup-aftereach-and-defercleanup
FYI: I try to run test with fixed loop and it fail, VM crushed, not sure why
But this test is doing good job to indicate problems
8e45dda to
909b24b
Compare
This commit adds two tests: 1. Upload files to the VM This test uploads three files of different sizes (10M, 100M, 1G) to the running VM and verifies the sha256sum of the uploaded files. 2. Download the above files from the VM This test downloads the three files uploaded in the previous test and verifies their sha256sum values. Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
909b24b to
0b09d74
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evidolob, lstocchi, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This pull request adds two tests:
Upload files to the VM This test uploads three files of different sizes (10M, 100M, 1G) to the running VM and verifies the sha256sum of the uploaded files.
Download the above files from the VM This test downloads the three files uploaded in the previous test and verifies their sha256sum values.