Use all configured ipv4 dns services#426
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Nov 15, 2024
Merged
Use all configured ipv4 dns services#426openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Collaborator
Author
|
cc @lstocchi |
397eace to
e9dc64b
Compare
cfergeau
reviewed
Nov 15, 2024
Collaborator
cfergeau
left a comment
There was a problem hiding this comment.
Looks good to me, just a few minor questions/suggestions.
It brings all ipv4 dns and make dns resolve request one by one until it receives first answer Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
e9dc64b to
d69e2ac
Compare
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398