Skip to content

Avoid crash with empty resolv.conf#420

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
siretart:issue/417
Nov 19, 2024
Merged

Avoid crash with empty resolv.conf#420
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
siretart:issue/417

Conversation

@siretart
Copy link
Copy Markdown

@siretart siretart commented Nov 8, 2024

Fixes: #417
Signed-off-by: Reinhard Tartler siretart@gmail.com

@siretart siretart mentioned this pull request Nov 8, 2024
Closed
@evidolob evidolob requested review from cfergeau and evidolob November 8, 2024 07:10
cfergeau
cfergeau reviewed Nov 8, 2024
View reviewed changes
@cfergeau
Copy link
Copy Markdown
Collaborator

cfergeau commented Nov 14, 2024

There is also this lint failure to fix:

cd tools && GOBIN="/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin" go install github.com/golangci/golangci-lint/cmd/golangci-lint
"/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin"/golangci-lint run
pkg/services/dns/dns_config_unix.go:6: File is not `goimports`-ed (goimports)
	"errors"
make: *** [Makefile:49: lint] Error 1

@siretart
Avoid crash with empty resolv.conf
fdcf750 
Fixes: containers#417
Signed-off-by: Reinhard Tartler <siretart@gmail.com>
@cfergeau
Copy link
Copy Markdown
Collaborator

cfergeau commented Nov 19, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, siretart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e0fa97 into containers:main Nov 19, 2024
This was referenced Dec 24, 2024
Closed
Merged
@jandubois jandubois mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfergeau cfergeau cfergeau left review comments

@evidolob evidolob Awaiting requested review from evidolob

Assignees

@cfergeau cfergeau

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panics on systems with empty /etc/resolv.conf

3 participants

@siretart @cfergeau @openshift-merge-robot