Check 'hosts' file records, during handling DNS requests#401
Conversation
0d206fc to
7f9dc16
Compare
cfergeau
left a comment
There was a problem hiding this comment.
Some questions/comments, but overall looks good!
pkg/services/dns/hosts_file.go
Outdated
|
|
||
| func (h *hosts) updateHostsFile() error { | ||
| h.hostsReadLock.RLock() | ||
| defer h.hostsReadLock.RUnlock() |
There was a problem hiding this comment.
This method is updating data structures (h) shared between multiple go routines, this should be taking a write lock (WLock())
You don't need to do it before the readHostsFile call though, as it's not changing any shared state, this could be moved just before h.hostsFile = newHosts
This implementation use 'libhosty' lib to read and search for hosts file records. It reads 'hosts' file first and adds file watcher to track changes in 'hosts' file Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
7f9dc16 to
3ea66d1
Compare
cfergeau
left a comment
There was a problem hiding this comment.
One pending comment, otherwise
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This implementation use 'libhosty' lib to read and search for hosts file records. It reads 'hosts' file first and adds file watcher to track changes in 'hosts' file