Switch tests from busybox to UBI10 and add consistent terminal size v…#612
Switch tests from busybox to UBI10 and add consistent terminal size v…#612jnovy merged 1 commit intocontainers:mainfrom
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
@ricardobranco777 @jankaluza This PR changes the tests to run solely on UBI10-micro removing busybox as a whole. This will allow us to actually run on top of full-featured and tested OS components. Reliability is a nice bonus. For that I needed to amend few tests and actually found a bug - we don't test upper limit for terminal size and kernel accepts only |
Unfortunately I can't properly test this PR because we're backporting these to an existing release (1.24) and the tests will fail as they rely on new functionality. It would help if the migration to UBI10 is done in a separate PR to just test that part. |
|
@ricardobranco777 These fixes unfortunately need to happen together because the previous tests were relying on fake busybox utility behaviour (not receiving a TTY). With UBI we got TTY so we can check live values. This is needed change otherwise tests in UBI10 would fail. |
Ok. I'll enable non-x86_64 tests hopefully on the next release. |
…alidation - Update Containerfile to use UBI10 base image instead of busybox - Replace busybox references with UBI10 commands in all test files - Add upper bound validation (1000) for terminal window size in ctrl.c to prevent wraparound bugs - Update CI/CD dependencies to include podman, bats, jq, and socat - Fix test assertions to expect proper terminal size behavior Fixes: containers#610 Signed-off-by: Jindrich Novy <jnovy@redhat.com>
|
LGTM |
…alidation
Fixes: #610