Replace Go tests with BATS and remove Go dependency#579
Merged
jnovy merged 1 commit intocontainers:mainfrom Aug 28, 2025
Merged
Replace Go tests with BATS and remove Go dependency#579jnovy merged 1 commit intocontainers:mainfrom
jnovy merged 1 commit intocontainers:mainfrom
Conversation
test/02-ctr-logs.bats
Outdated
| } | ||
|
|
||
| @test "ctr logs: log driver as journald with short cid should fail" { | ||
| local short_ctr_id="abcdefghijkl" |
Collaborator
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
actually a number of these do
| @@ -1,19 +0,0 @@ | |||
| package config | |||
Collaborator
There was a problem hiding this comment.
do we know nothing imports these still? I did feel clever about generating them but we never actually changed it really so I understand dropping
Reimplemented all tests from Go to BATS framework, providing comprehensive test coverage while eliminating Go build dependencies. Added 52 BATS tests covering basic functionality, container logging, k8s log rotation, and full runtime integration with real container execution. Fixes: containers#577 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jindrich Novy <jnovy@redhat.com>
Collaborator
Author
|
Thanks @haircommander for the review - the two tests were indeed duplicated. Duplicate Tests Fixed:
Seems no remaining files import or reference the deleted modules (runner/config, runner/conmon, cmd/conmon-config). |
Collaborator
|
LGTM, thanks! |
Contributor
|
Thanks for these tests. I could backport this to run on conmon 2.1.13 and 2.1.10 for openSUSE & SUSE and they pass on all arches. |
Collaborator
Author
|
Perfect, thanks for confirming @ricardobranco777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented all tests from Go to BATS framework, providing comprehensive test coverage while eliminating Go build dependencies. Added 50 BATS tests covering basic functionality, container logging, k8s log rotation, and full runtime integration with real container execution.
Fixes: #577