OCPBUGS-4556: src: Fix terminal resize event processing#566
Merged
giuseppe merged 1 commit intocontainers:mainfrom Jun 13, 2025
Merged
OCPBUGS-4556: src: Fix terminal resize event processing#566giuseppe merged 1 commit intocontainers:mainfrom
giuseppe merged 1 commit intocontainers:mainfrom
Conversation
This was referenced Jun 12, 2025
The fix ensures each complete line in the control buffer is processed exactly once by passing the correct line start position to the processing function and properly null-terminating each line. Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
ac8c925 to
2a1dda8
Compare
Collaborator
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple resize events are sent rapidly, only the first event was being processed correctly. Subsequent events in the
same buffer were ignored because
read_from_ctrl_buffer()always processed from the beginning of the buffer instead of the current line position. This caused terminals to get stuck at incorrect dimensions, particularly during kubectl/oc debug sessions where resize events are common. The fix ensures each complete line in the control buffer is processed exactly once by passing the correct line start position to the processing function and properly null-terminating each line.