Merged
Conversation
Because actions/setup-go does its own caching now, adding our own: - unnecessarily complicates things; - results in double caching. Remove it. Note that a single common cache will be used between the two jobs (which is OK). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The version of go-md2man is quite old, and is not really need to be in this repository. It is only used by `make docs` which does not make sense to run in CI, as we don't check the resulting man page. PS if needed, it is easy to install by this one-liner: go install github.com/cpuguy83/go-md2man/v2@latest Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Apparently, since the master branch was renamed to main a few years back, GHA CI jobs no longer run when a PR is merged. Fix that. While at it, add some vertical whitespace. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The sole reason is to simplify branch protection rules, requiring just these to be passed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This repo never had ./vendor committed, so it's of little use, especially with modern Go caching and proxying. So, let's remove "go mod vendor" from the make's vendor target, and also remove "make vendor" from the integration / conmon CI job. Instead, add a separate GHA job to check for go.mod/go.sum correctness. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is not used since commit 4e61870 ("gh actions: drop perma-failing jobs"). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The sole reason of having this was to produce a nice informative error message in case of failure (and because the message was not explicitly specified, it was entirely wrong in 1 of 2 use cases). Let's drop it and just use git to fail the job if a tree is dirty. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
We can use git ls-files for clang-format, and gofmt directly for Go (as we don't have vendor). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1 task
Collaborator
|
LGTM, we depend on the external go-md2man anyway, there seems to be no longer a need to vendor it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main).Please review commit-by-commit, and see individual commit descriptions for more details.
Closes: #412