Merged
Conversation
The github.com/pkg/errors is frozen since November 2021, and %w for fmt.Errorf is available since Go 1.13 (September 2019). Switch from pkg/errors to Go native way of wrapping errors. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The io/ioutil package is deprecated since Go 1.16, so let's switch to os for ReadFile and WriteFile. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The testing.TempDir function is available since Go 1.15. Since tests are written using ginkgo, use GinkgoT to obtain *testing.T. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was introduced in commit 31c5a2e ("add tests running a runtime") but was not used ever. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Probably a leftover from developing tests. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Apparently the code is well formatted, except for 0oNNN for octal numbers (available since Go 1.13). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
|
LGTM |
Collaborator
|
LGTM too, thanks for this Kir! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few minor issues with go code in this repo:
0oprefix.