sock_try_write_to_local_sock: improve a warning#556
Closed
kolyshkin wants to merge 1 commit intocontainers:mainfrom
Closed
sock_try_write_to_local_sock: improve a warning#556kolyshkin wants to merge 1 commit intocontainers:mainfrom
kolyshkin wants to merge 1 commit intocontainers:mainfrom
Conversation
Make sure we show errno, and tell if the write was to a socket. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
|
While technically correct, I'd still prefer #554 for the sake of code readability :-) |
Member
|
As #554 has merged, should this be closed? |
Collaborator
|
Yep, closing. Thanks @kolyshkin - feel free to follow up with further refinements, there's still plenty of things to fix here :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we show errno, and tell if the write was to a socket.
Related to #540. Alternative to #554.