Merged
Conversation
The ndebugf macro already adds \n so we don't have to. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1. Use nwarn instead of pwarn since we're not interested in errno here. 2. Add some context to the message. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
And convert 2 of its users to use nwarnf with %m. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
jnovy
requested changes
Apr 23, 2025
Collaborator
jnovy
left a comment
There was a problem hiding this comment.
Thanks for this, just one comment related to malloc() + errno.
In here, error and errorf print strerror(errno), but the only case errno is set is when malloc() fails (and the errno is invariably ENOMEM so it doesn't make much sense to print it anyway). 1. Remove adding strerror(errno) from these macros. 2. Redefine error via errorf to simplify. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
While %m is GNU extension, it is also supported by alternative libc versions (uclibc, musl) as well as by FreeBSD 12+. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
|
All good now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into how conmon logs things and found out a few things that can be improved, so here's this.
Please review commit by commit; see individual commits for details.